Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(writer): Add writer objects to go to.idf #36

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

chriswmackey
Copy link
Member

Working with the new structure of honeybee-core writers. This commit officially brings everything together to make a simulate-able IDF!

@chriswmackey chriswmackey added critical Features/fixes that are critical to continued development new development For issues that require new code labels Oct 18, 2019
@chriswmackey
Copy link
Member Author

Sorry for pushing changes so many times. This is officially ready to be reviewed/merged and I can say (AT LAST!) that IDFs produced by this code have been run through EnergyPlus!

Copy link
Member

@mostaphaRoudsari mostaphaRoudsari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See my comments.

honeybee_energy/properties/model.py Show resolved Hide resolved
honeybee_energy/properties/model.py Show resolved Hide resolved
honeybee_energy/schedule/day.py Show resolved Hide resolved
honeybee_energy/simulationparameter.py Outdated Show resolved Hide resolved
honeybee_energy/simulationparameter.py Show resolved Hide resolved
honeybee_energy/writer.py Show resolved Hide resolved
honeybee_energy/writer.py Outdated Show resolved Hide resolved
honeybee_energy/writer.py Show resolved Hide resolved
honeybee_energy/writer.py Show resolved Hide resolved
Working with the new structure of honeybee-core writers. This commit officially brings everything together to make a simulate-able IDF!
@ladybugbot
Copy link
Contributor

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Features/fixes that are critical to continued development done energy honeybee new development For issues that require new code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants